Upgrade deps, fix several broken tests on main
#2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Game Finder and MS test deps. Also fixes the following broken behavior on
mainThe ModType used capital letters for the enum of
BrowseandDirectmeaning that those collections were not parsable. This fixes that behavior. We really need to be running all the unit tests more often.The LoginManager was borked, using a
CachedObjectbut not changingUserInfoto point to this new cache, so depending on how logins were performed half the login manager wouldn't see the data. Also would have been caught by running the tests.